[webkit-reviews] review denied: [Bug 58396] [Qt] http/tests/misc/favicon-loads-with-icon-loading-override.html fails : [Attachment 89320] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 26 16:04:28 PDT 2011
Tor Arne Vestbø <vestbo at webkit.org> has denied Alice Liu
<alice.liu at apple.com>'s request for review:
Bug 58396: [Qt] http/tests/misc/favicon-loads-with-icon-loading-override.html
fails
https://bugs.webkit.org/show_bug.cgi?id=58396
Attachment 89320: patch
https://bugs.webkit.org/attachment.cgi?id=89320&action=review
------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89320&action=review
> Source/WebKit/qt/Api/qwebsettings.h:81
> + LoadSiteIcons
The preference is only applicable if AutoLoadImages has been disabled, and the
enum name should reflect that. AlwaysLoadSiteIcons perhaps?
More information about the webkit-reviews
mailing list