[webkit-reviews] review denied: [Bug 47769] [chromium] Keyboard+mouse selection in select popups only updated after unfocused : [Attachment 81604] Addressing fishd comment

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Jay Civelli <jcivelli at chromium.org>'s
request for review:
Bug 47769: [chromium] Keyboard+mouse selection in select popups only updated
after unfocused
https://bugs.webkit.org/show_bug.cgi?id=47769

Attachment 81604: Addressing fishd comment
https://bugs.webkit.org/attachment.cgi?id=81604&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81604&action=review

Just one concern. Otherwise the patch looks fine.

> Source/WebKit/chromium/src/WebViewImpl.cpp:570
> +    // If there is a select popup, it should be the one processing the
event,
> +    // not the page.
> +    if (m_selectPopup)
> +	   return
m_selectPopup->handleKeyEvent(PlatformKeyboardEventBuilder(event));

seems like this should be after we set m_suppressNextKeypressEvent to false,
no?

> Source/WebKit/chromium/src/WebViewImpl.cpp:687
> +    // If there is a select popup, it should be the one processing the
event,
> +    // not the page.
> +    if (m_selectPopup)
> +	   return
m_selectPopup->handleKeyEvent(PlatformKeyboardEventBuilder(event));

seems like this should be after we set m_suppressNextKeypressEvent to false,
no?