[webkit-reviews] review denied: [Bug 49184] [Qt] Flawed rendering design for QtWebKit resulting in artifacts being displayed : [Attachment 80502] Proposed Patch. Updated to match current Webkit Source Code structure

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Carol Szabo <carol at webkit.org>'s
request for review:
Bug 49184: [Qt] Flawed rendering design for QtWebKit resulting in artifacts
being displayed
https://bugs.webkit.org/show_bug.cgi?id=49184

Attachment 80502: Proposed Patch. Updated to match current Webkit Source Code
structure
https://bugs.webkit.org/attachment.cgi?id=80502&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80502&action=review

> Source/WebKit/qt/Api/qwebframe.cpp:1219
> +  \since unreleased

We don't use this, better use \since 4.8 or nothing at all. :)

> Source/WebKit/qt/Api/qwebframe.cpp:1234
> +void QWebFrame::updateView(QWidget* view, QPainter* painter,  RenderLayer
layer, const QRegion& currentDirtyRegion)

Double spaces before RenderLayer

> Source/WebKit/qt/Api/qwebframe.cpp:1238
> +    GraphicsContext context(painter);
> +    if (context.paintingDisabled() && !context.updatingControlTints())
> +	   return;

This code looks strange. Since you're creating the GraphicsContext here, just
do if (!painter) return;

> Source/WebKit/qt/Api/qwebframe.h:176
> +    void updateView(QWidget* view, QPainter*,  RenderLayer, const QRegion&
currentDirtyRegion);

Two spaces after QPainter*,