[webkit-reviews] review granted: [Bug 55953] [QT][S60] Building QtTestBrowser alone on symbian fix : [Attachment 85067] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 15:38:32 PDT 2011


Simon Hausmann <hausmann at webkit.org> has granted Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 55953: [QT][S60] Building QtTestBrowser alone on symbian fix
https://bugs.webkit.org/show_bug.cgi?id=55953

Attachment 85067: patch
https://bugs.webkit.org/attachment.cgi?id=85067&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85067&action=review

I'm going to say r+, but please fix the style issues before landing

> Tools/QtTestBrowser/QtTestBrowser.pro:27
> +symbian:INCLUDEPATH+=../../Source/include/QtWebKit

Style nitpick: space after : and before/after +=


More information about the webkit-reviews mailing list