[webkit-reviews] review denied: [Bug 51099] [Qt] QWebPagePrivate::inputMethodEvent has problem when compositing Korean : [Attachment 76730] [Qt] QWebPagePrivate::inputMethodEvent has problem when compositing Korean

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Hwang <luxtella at company100.net>'s
request for review:
Bug 51099: [Qt] QWebPagePrivate::inputMethodEvent has problem when compositing
Korean
https://bugs.webkit.org/show_bug.cgi?id=51099

Attachment 76730: [Qt] QWebPagePrivate::inputMethodEvent has problem when
compositing Korean
https://bugs.webkit.org/attachment.cgi?id=76730&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76730&action=review

How can we test this?

> WebKit/qt/Api/qwebpage.cpp:1098
> +	   // that the caret is vanished. after finishing composition, caret
should
> +	   // be visible.

Grammar.
When compositing Korean, 'ev' is of type Cursor with length=0. This causes the
caret to vanish. After the composition finishes, the caret should be visible.

> WebKit/qt/Api/qwebpage.cpp:1102
> +	   // If preeditSting exists, Caret should be visible.

preeditSting -> preeditString
Caret -> the caret

> WebKit/qt/Api/qwebpage.cpp:1105
> +	   // next to composition, not in front of composition.

next to composition -> next to the composition
in front of composition -> in front of the composition