[webkit-reviews] review denied: [Bug 56200] [GTK] WebKitIconDatabase doesn't keep icons cached : [Attachment 87701] New API for WebKitIconDatabase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 15:36:25 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 56200: [GTK] WebKitIconDatabase doesn't keep icons cached
https://bugs.webkit.org/show_bug.cgi?id=56200

Attachment 87701: New API for WebKitIconDatabase
https://bugs.webkit.org/attachment.cgi?id=87701&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
As I said in person, this patch is awesome. Other than the nits that I
mentioned I would switch to representing the IconDatabaseClient virtual methods
with three separate signals though. Thanks!


More information about the webkit-reviews mailing list