[webkit-reviews] review denied: [Bug 51170] [Qt] The IME composition is strangely affected by another text field : [Attachment 76741] Amended EditorClientQt::textFieldDidEndEditing(Element*)

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Hwang <luxtella at company100.net>'s
request for review:
Bug 51170: [Qt] The IME composition is strangely affected by another text field
https://bugs.webkit.org/show_bug.cgi?id=51170

Attachment 76741: Amended EditorClientQt::textFieldDidEndEditing(Element*)
https://bugs.webkit.org/attachment.cgi?id=76741&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76741&action=review

> WebKit/qt/ChangeLog:13
> +	   Need a short description and bug URL (OOPS!)

This line needs to be removed.

> WebKit/qt/WebCoreSupport/EditorClientQt.cpp:502
> +	   // Notify qwidget to complete the text composition.

qwidget -> QWidget

> WebKit/qt/WebCoreSupport/EditorClientQt.cpp:505
> +	   // Notify WebCore::Editor to complete the text composition.
> +	   frame->editor()->confirmComposition();

The comment is redundant.