[webkit-reviews] review denied: [Bug 59411] [EFL] Change cursor to LAZY_NATIVE_CURSOR : [Attachment 91051] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 26 15:11:17 PDT 2011
Eric Seidel <eric at webkit.org> has denied Ryuan Choi <ryuan.choi at samsung.com>'s
request for review:
Bug 59411: [EFL] Change cursor to LAZY_NATIVE_CURSOR
https://bugs.webkit.org/show_bug.cgi?id=59411
Attachment 91051: Patch
https://bugs.webkit.org/attachment.cgi?id=91051&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91051&action=review
Looks fine except for the , strangeness. I think we only do the leading comma
for initializer lists.
> Source/WebCore/platform/efl/CursorEfl.cpp:62
> + "cursor/pointer"
> + , "cursor/cross"
I think we would normally write this "foo", and put a comma after every line.
But I'm not sure.
> Source/WebCore/platform/efl/CursorEfl.cpp:104
> + , ""};
What's this for?
More information about the webkit-reviews
mailing list