[webkit-reviews] review requested: [Bug 56375] [Qt] PageGroup::closeLocalStorage() should be called when the app quits : [Attachment 91169] Close Icon and Local Storage Databases on Quit

[bugzilla-daemon at webkit.org]

Joe Wild <joseph.wild at nokia.com> has asked  for review:
Bug 56375: [Qt] PageGroup::closeLocalStorage() should be called when the app
quits
https://bugs.webkit.org/show_bug.cgi?id=56375

Attachment 91169: Close Icon and Local Storage Databases on Quit
https://bugs.webkit.org/attachment.cgi?id=91169&action=review

------- Additional Comments from Joe Wild <joseph.wild at nokia.com>
Added QWebView::shutDownWebKit to close the Icon and Local Storage Databases.
This Signal was connected to the application's aboutToQuit Slot.

    connect(QCoreApplication::instance(), SIGNAL(aboutToQuit()),
	    this, SLOT(shutDownWebKit()));

This was suggested in the error and as is done on other platforms (Windows).
Then I connected the Signal lastWindowClosed to Slot quit(), so
aboutToQuit would be signaled.

    connect(QApplication::instance(), SIGNAL(lastWindowClosed()),
	QApplication::instance(), SLOT(quit()));

It turns out that calling WebCore::PageGroup::closeLocalStorage() does
not close the local storage.  Local storage is closed the
WebCore::PageGroup is destroyed.  I kept the call to
closeLocalStorage() because it was consistent with other platforms and
does not hurt anything.  Calling WebCore::iconDatabase()->close() in
shutDownWebKit does close that db.

This was clean up which did not change any functionality, so did not
add any new tests.