[webkit-reviews] review denied: [Bug 59409] Drag images not generated for anchors when drag is initiated via the anchor text : [Attachment 91060] Patch

[bugzilla-daemon at webkit.org]

Daniel Cheng <dcheng at chromium.org> has denied Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 59409: Drag images not generated for anchors when drag is initiated via the
anchor text
https://bugs.webkit.org/show_bug.cgi?id=59409

Attachment 91060: Patch
https://bugs.webkit.org/attachment.cgi?id=91060&action=review

------- Additional Comments from Daniel Cheng <dcheng at chromium.org>
(In reply to comment #6)
> This looks confusing to me. What if there are actually several nested
draggable elements, and the user is dragging an innermost one?


(Note I'm assuming that draggable is implemented in these examples, while it
currently isn't)

Case 1:
<a href="foo.html">Link</a>

Anchors default to draggable="true". However, right now, a drag started by a
click on "Link" is treated as if only the anonymous text node were dragged. You
have to start the drag on the padding area (I think) to get a drag image to be
rendered for the anchor element.

Case 2:
<div draggable>Draggable text with a <a href="foo.html">link</a><div>Div inside
a div</div></div>

Dragging the anchor will result in just the anchor getting dragged (on Firefox
and Chrome). But starting a drag on any other element inside the div will
result in the entire div getting dragged.

I think case 1 is something that we should fix. Case 2 is weird but will
probably require a more authoritative statement from the spec. The attached
patch doesn't really address case 1 correctly though, so I'm marking it as R-
while I debate a better fix...