[webkit-reviews] review granted: [Bug 59487] OwnPtr assignment operator should be private : [Attachment 91150] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 14:05:36 PDT 2011


Kenneth Russell <kbr at google.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 59487: OwnPtr assignment operator should be private
https://bugs.webkit.org/show_bug.cgi?id=59487

Attachment 91150: Patch
https://bugs.webkit.org/attachment.cgi?id=91150&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
This is important to fix as it allowed
https://bugs.webkit.org/show_bug.cgi?id=59459 to creep in during the strict
OwnPtr cleanup yesterday. I wonder whether it's worth a comment directly above
the new private assignment operator indicating why it's necessary. Looks good
to me otherwise.


More information about the webkit-reviews mailing list