[webkit-reviews] review granted: [Bug 59464] Fix more strict OwnPtr in WebCore (round N). : [Attachment 91117] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 26 09:48:52 PDT 2011
Darin Adler <darin at apple.com> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 59464: Fix more strict OwnPtr in WebCore (round N).
https://bugs.webkit.org/show_bug.cgi?id=59464
Attachment 91117: Patch
https://bugs.webkit.org/attachment.cgi?id=91117&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91117&action=review
> Source/WebCore/fileapi/FileReader.cpp:171
> - m_loader = 0;
> + m_loader.clear();
Anders Carlsson would much prefer that we use "= nullptr" rather than
"clear()".
> Source/WebCore/loader/DocumentThreadableLoader.cpp:334
> - m_actualRequest = 0; // Prevent didFinishLoading() from bypassing access
check.
> + m_actualRequest.clear(); // Prevent didFinishLoading() from bypassing
access check.
Ditto.
More information about the webkit-reviews
mailing list