[webkit-reviews] review denied: [Bug 59326] Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text : [Attachment 91118] [PATCH] Improved solution

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 59326: Web Inspector: Use CachedResource to retrieve charset-decoded
stylesheet text
https://bugs.webkit.org/show_bug.cgi?id=59326

Attachment 91118: [PATCH] Improved solution
https://bugs.webkit.org/attachment.cgi?id=91118&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91118&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:67
> +bool decodeSharedBuffer(PassRefPtr<SharedBuffer> buffer, const String&
textEncodingName, String* result)

Please make this static.

> Source/WebCore/inspector/InspectorPageAgent.cpp:79
> +bool prepareCachedResourceBuffer(CachedResource* cachedResource, bool*
hasZeroSize)

Ditto.

> Source/WebCore/inspector/InspectorPageAgent.cpp:105
> +bool cachedResourceDecoded(CachedResource* cachedResource, String* result)

ditto. decodeCachedResource ?

> Source/WebCore/inspector/InspectorPageAgent.cpp:131
> +PassRefPtr<SharedBuffer> mainResourceSharedBuffer(Frame* frame, const KURL&
url, String* textEncodingName)

ditto

> Source/WebCore/inspector/InspectorPageAgent.cpp:135
> +    if (equalIgnoringFragmentIdentifier(url, loader->url())) {

You should only enter mainResourceSharedBuffer for main resource urls.