[webkit-reviews] review granted: [Bug 59437] Moar strict OwnPtr fixes for WebKit/chromium : [Attachment 91109] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 59437: Moar strict OwnPtr fixes for WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=59437

Attachment 91109: Patch
https://bugs.webkit.org/attachment.cgi?id=91109&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91109&action=review

Glad you got rid of the exit time destructor (as it bothered me too when I
glanced at this before going off to bed).

Only one comment to consider.

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:319
> +void WebDevToolsAgent::interruptAndDispatch(MessageDescriptor*
rawDescriptor)

Yeah for decent variable names.

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:342
> +    PageScriptDebugServer::interruptAndRun(new
DebuggerTask(descriptor.release()));

Seems odd that there is no adopt of the "new DebuggerTask" here.