[webkit-reviews] review granted: [Bug 59439] [Qt] Implement LayoutTestController::setAutofilled : [Attachment 91093] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 06:08:19 PDT 2011


Csaba Osztrogonac <ossy at webkit.org> has granted Kristóf Kosztyó
<Kosztyo.Kristof at stud.u-szeged.hu>'s request for review:
Bug 59439: [Qt] Implement LayoutTestController::setAutofilled
https://bugs.webkit.org/show_bug.cgi?id=59439

Attachment 91093: proposed fix
https://bugs.webkit.org/attachment.cgi?id=91093&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91093&action=review

LGTM, r=me. (Apart from some minor thing, what I'll fix before landing.)

> LayoutTests/platform/qt/Skipped:-723
> -# Missing layoutTestController.overridePreference()
> -fast/events/pageshow-pagehide-on-back-cached.html
> -fast/events/pageshow-pagehide-on-back-cached-with-frames.html
> -

This change is unrelated to this bug.

> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:246
> +	   return;

Add a newline after it.


More information about the webkit-reviews mailing list