[webkit-reviews] review granted: [Bug 59429] Fix last strict OwnPtr violation under svg/... : [Attachment 91075] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 00:24:56 PDT 2011


Adam Barth <abarth at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 59429: Fix last strict OwnPtr violation under svg/...
https://bugs.webkit.org/show_bug.cgi?id=59429

Attachment 91075: Patch
https://bugs.webkit.org/attachment.cgi?id=91075&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91075&action=review

> Source/WebCore/svg/SVGDocumentExtensions.cpp:243
> -    OwnPtr<SVGPendingElements> set(m_pendingResources.get(id));
> +    OwnPtr<SVGPendingElements> set(adoptPtr(m_pendingResources.get(id)));

We prefer the assignment form of the constructor:

OwnPtr<SVGPendingElements> set = adoptPtr(m_pendingResources.get(id));


More information about the webkit-reviews mailing list