[webkit-reviews] review granted: [Bug 59405] DFG JIT - add type speculation for integer & array types, for vars & args. : [Attachment 91030] The patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 59405: DFG JIT - add type speculation for integer & array types, for vars &
args.
https://bugs.webkit.org/show_bug.cgi?id=59405

Attachment 91030: The patch
https://bugs.webkit.org/attachment.cgi?id=91030&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91030&action=review

r=me

> Source/JavaScriptCore/dfg/DFGGraph.h:141
> +	   if (operand < 0) {

Probably worth a helper function to abstract away the fact that a negative
number means an argument.

> Source/JavaScriptCore/dfg/DFGGraph.h:151
> +	   if (operand < 0) {

Ditto.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:290
> +	       // integerResult, but don't useChildren!

Not new to this patch, but it would be good to explain the why here (phi
nodes), instead of the what.