[webkit-reviews] review denied: [Bug 59264] [chromium] Implement EditorClient::canCopyCut and EditorClient::canPaste : [Attachment 90822] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 25 16:50:04 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 59264: [chromium] Implement EditorClient::canCopyCut and
EditorClient::canPaste
https://bugs.webkit.org/show_bug.cgi?id=59264

Attachment 90822: Patch
https://bugs.webkit.org/attachment.cgi?id=90822&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90822&action=review

> Source/WebKit/chromium/public/WebViewClient.h:318
> +    virtual bool canTriggerClipboardRead(const WebURL& url) { return false;
}

nit: webkit style is to drop the parameter name when the name is just a clone
of the type name.

nit: these functions are listed in the "Zoom" section, but they don't seem to
have anything
to do with zooming.  it looks like registerProtocolHandler was improperly
placed here too!


More information about the webkit-reviews mailing list