[webkit-reviews] review denied: [Bug 59395] Fix OwnPtr strict errors in some SVG classes. : [Attachment 91013] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Adam Klein
<adamk at chromium.org>'s request for review:
Bug 59395: Fix OwnPtr strict errors in some SVG classes.
https://bugs.webkit.org/show_bug.cgi?id=59395

Attachment 91013: Patch
https://bugs.webkit.org/attachment.cgi?id=91013&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91013&action=review

so close!

> Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp:166
> +    , shadow(other.shadow ? adoptPtr(new ShadowData(*other.shadow)) :
PassOwnPtr<ShadowData>(0))

PassOwnPtr<ShadowData>(), no '0'

> Source/WebCore/svg/SVGStyledTransformableElement.cpp:68
> +	   m_supplementalTransform = adoptPtr(new AffineTransform());

nit: don't need the ()s on this c'tor

> Source/WebCore/svg/SVGTextElement.cpp:100
> +	   m_supplementalTransform = adoptPtr(new AffineTransform());

nit: don't need the ()s on this c'tor