[webkit-reviews] review granted: [Bug 59378] WebKit2: Should be able to inspect Web Inspector in Debug Builds : [Attachment 91011] [PATCH] Fix v2

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 59378: WebKit2: Should be able to inspect Web Inspector in Debug Builds
https://bugs.webkit.org/show_bug.cgi?id=59378

Attachment 91011: [PATCH] Fix v2
https://bugs.webkit.org/attachment.cgi?id=91011&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91011&action=review

> Source/WebKit2/ChangeLog:9
> +	   (WebKit::WebInspectorProxy::createInspectorPageGroup): Creates an
inspector page group and enables

The "WebInspectorProxy::" part of this line is incorrect.

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:50
> +static WebPageGroup* createInspectorPageGroup()
> +{
> +    WebPageGroup* pageGroup =
WebPageGroup::create("__WebInspectorPageGroup__", false, false).leakRef();

You should make this function return a PassRefPtr and put the leakRef at the
call site.