[webkit-reviews] review denied: [Bug 59378] WebKit2: Should be able to inspect Web Inspector in Debug Builds : [Attachment 90984] [PATCH] Fix

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 59378: WebKit2: Should be able to inspect Web Inspector in Debug Builds
https://bugs.webkit.org/show_bug.cgi?id=59378

Attachment 90984: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=90984&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90984&action=review

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:62
>  WebPageGroup* WebInspectorProxy::inspectorPageGroup()
>  {
> -    static WebPageGroup* pageGroup =
WebPageGroup::create("__WebInspectorPageGroup__", false, false).leakRef();
> +    static WebPageGroup* pageGroup;
> +    if (pageGroup)
> +	   return pageGroup;
> +
> +    pageGroup = WebPageGroup::create("__WebInspectorPageGroup__", false,
false).leakRef();
> +
> +#ifndef NDEBUG
> +    // Allow developers to inspect the Web Inspector in debug builds.
> +    pageGroup->preferences()->setDeveloperExtrasEnabled(true);
> +#endif
> +
>      return pageGroup;
>  }

I think it would be clearer to add a separate createInspectorPageGroup() helper
function that had all the creation code. Then this function could stay simple.