[webkit-reviews] review granted: [Bug 59382] WebCore/css/CSS* files should play nice with strict OwnPtrs : [Attachment 90988] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 25 16:20:04 PDT 2011


David Levin <levin at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 59382: WebCore/css/CSS* files should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59382

Attachment 90988: Patch
https://bugs.webkit.org/attachment.cgi?id=90988&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90988&action=review

two nits to fix.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

Fix this :)

> Source/WebCore/css/CSSFontFaceSource.cpp:167
>									       
      fontDescription.textOrientation(), fontDescription.widthVariant(),
fontDescription.renderingMode()), true, false));

This should be indented further.


More information about the webkit-reviews mailing list