[webkit-reviews] review granted: [Bug 59311] [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint() : [Attachment 90900] Patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 59311: [GTK] Crash in
WebCore::FrameView::notifyPageThatContentAreaWillPaint()
https://bugs.webkit.org/show_bug.cgi?id=59311

Attachment 90900: Patch
https://bugs.webkit.org/attachment.cgi?id=90900&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90900&action=review

r=me with that check.

> Source/WebCore/platform/gtk/MainFrameScrollbarGtk.cpp:72
> +    // In some cases this adjustment may still be attached to a living
MainFrameScrollbar.

I suppose we don't really know when this happens?

> Source/WebCore/platform/gtk/MainFrameScrollbarGtk.cpp:80
> +					    0,
reinterpret_cast<void*>(MainFrameScrollbarGtk::gtkValueChanged), 0);

Double check that you really need the signal id and the detail.