[webkit-reviews] review granted: [Bug 59315] REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation) : [Attachment 90905] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted mitz at webkit.org's request for
review:
Bug 59315: REGRESSION (WK2): Holding down Option while dragging scrollbar thumb
has no effect (should make scroll distance equal mouse translation)
https://bugs.webkit.org/show_bug.cgi?id=59315

Attachment 90905: Patch
https://bugs.webkit.org/attachment.cgi?id=90905&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90905&action=review

r=me but consider the naming.

> Source/WebCore/platform/Scrollbar.cpp:259
> +void Scrollbar::moveThumb(int pos, bool draggingDocument)

draggingDocument doesn't seem like a very clear name for what the different
behavior is. Is there a way to name this more clearly?

I would suggest an enum instead of a bool here, but the usage seems clear at
the one call site, so I won't.