[webkit-reviews] review granted: [Bug 59280] [Refactoring] NodeRenderParentDetector should be NodeRenderParentFacotry : [Attachment 90861] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 59280: [Refactoring] NodeRenderParentDetector should be
NodeRenderParentFacotry
https://bugs.webkit.org/show_bug.cgi?id=59280

Attachment 90861: Patch
https://bugs.webkit.org/attachment.cgi?id=90861&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90861&action=review

ok with nits.

> Source/WebCore/ChangeLog:5
> +	   [Refactoring] NodeRenderParentDetector should have its own file

Need to change the title here too.

> Source/WebCore/dom/Node.cpp:1614
> +    return
NodeRendererFactory(const_cast<Node*>(this)).parentNodeForRenderingAndStyle();

Should we just remove the const modifier on the calling method?