[webkit-reviews] review denied: [Bug 59138] REGRESSION(81625): Tables are not rendered correctly : [Attachment 90842] bug fix with comment moved

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Rik Cabanier
<cabanier at adobe.com>'s request for review:
Bug 59138: REGRESSION(81625): Tables are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=59138

Attachment 90842: bug fix with comment moved
https://bugs.webkit.org/attachment.cgi?id=90842&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90842&action=review

> Source/WebCore/rendering/AutoTableLayout.cpp:270
> +    } else if (!remainingPercent && maxNonPercent)
> +	   // if there was no remaining percent, maxWidth is invalid.
>	   maxWidth = intMaxForLength;	      

Braces are preferred when a comment is included above a single-line clause.

> LayoutTests/fast/table/auto-100-percent-width.html:9
> +function test()
> +{
> +    if (window.layoutTestController)
> +	   layoutTestController.dumpAsText();
> +}
> +</script>

The dumpAsText() makes this a text test, so the output doesn't show the sizes
of the render objects. You can see the output above; how does that reveal
whether the bug is fixed?

Part of your workflow should be to ensure that the LayoutTest reproduces
failure without the fix in the code.

I think in this case you can just remove the entire <script> block. The <div>
is also unnecessary.