[webkit-reviews] review denied: [Bug 59138] REGRESSION(81625): Tables are not rendered correctly : [Attachment 90841] bug fix with testcase

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Rik Cabanier
<cabanier at adobe.com>'s request for review:
Bug 59138: REGRESSION(81625): Tables are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=59138

Attachment 90841: bug fix with testcase
https://bugs.webkit.org/attachment.cgi?id=90841&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90841&action=review

r- for lack of working test.

> Source/WebCore/rendering/AutoTableLayout.cpp:270
> +    } else
>      // if there was no remaining percent, maxWidth is invalid.
>      if (!remainingPercent && maxNonPercent)

I'd prefer the 'else if' together, and the comment after the condition

> LayoutTests/fast/table/auto-100-percent-width.html:8
> +function test()
> +{
> +    if (window.layoutTestController)
> +	   layoutTestController.dumpAsText();
> +}

Where is the test code?