[webkit-reviews] review granted: [Bug 59256] only include failures in full_results.json : [Attachment 90801] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 22 19:17:23 PDT 2011


Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 59256: only include failures in full_results.json
https://bugs.webkit.org/show_bug.cgi?id=59256

Attachment 90801: Patch
https://bugs.webkit.org/attachment.cgi?id=90801&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90801&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:128
> +	   test_dict = {}

It would be nice to just make these structs at some point.

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:130
> +	   if False:
> +	       test_dict['has_stderr'] = True

Debugging code?


More information about the webkit-reviews mailing list