[webkit-reviews] review granted: [Bug 58953] [V8] Use implicit references for V8 listeners on DOM nodes. : [Attachment 90823] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Vitaly Repeshko
<vitalyr at chromium.org>'s request for review:
Bug 58953: [V8] Use implicit references for V8 listeners on DOM nodes.
https://bugs.webkit.org/show_bug.cgi?id=58953

Attachment 90823: patch
https://bugs.webkit.org/attachment.cgi?id=90823&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90823&action=review

> Source/WebCore/dom/EventTarget.cpp:394
> +EventListenerIterator::EventListenerIterator() : m_index(0)

Sorry, this initializer needs to be on its own line too.

> Source/WebCore/dom/EventTarget.h:197
> +	   EventListener* nextListener();

I would add a comment admonishing folks not to modify the listener list durning
iteration because that will cause big problems for this iterator.