[webkit-reviews] review granted: [Bug 59253] CommitQueue should remember the expected failures from patch to patch : [Attachment 90799] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 22 16:27:17 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 59253: CommitQueue should remember the expected failures from patch to
patch
https://bugs.webkit.org/show_bug.cgi?id=59253

Attachment 90799: Patch
https://bugs.webkit.org/attachment.cgi?id=90799&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90799&action=review

Otherwise looks fine.

> Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py:69
> -	   self._expected_failures = ExpectedFailures()
> +	   self._expected_failures = delegate.expected_failures()

Looks like we should jus tpass them into the constructor instead.


More information about the webkit-reviews mailing list