[webkit-reviews] review granted: [Bug 59246] Let the RenderTheme decide if an input type should have a spinner : [Attachment 90777] [PATCH] Let RenderTheme make the decisions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 22 15:31:10 PDT 2011


Kent Tamura <tkent at chromium.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 59246: Let the RenderTheme decide if an input type should have a spinner
https://bugs.webkit.org/show_bug.cgi?id=59246

Attachment 90777: [PATCH] Let RenderTheme make the decisions
https://bugs.webkit.org/attachment.cgi?id=90777&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90777&action=review

> Source/WebCore/rendering/RenderTheme.h:206
> +    // Return true if the input element should have a spin button.
> +    virtual bool shouldHaveSpinButtonForInputElement(InputElement*) const;

nit: The comment might be unnecessary.
nit: "ForInputElement" in the function name is redundant.  We may remove it.


More information about the webkit-reviews mailing list