[webkit-reviews] review granted: [Bug 59244] Factor LayoutTestResultsReader out of CommitQueue : [Attachment 90774] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 59244: Factor LayoutTestResultsReader out of CommitQueue
https://bugs.webkit.org/show_bug.cgi?id=59244

Attachment 90774: Patch
https://bugs.webkit.org/attachment.cgi?id=90774&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90774&action=review

> Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py:39
> +	   self._log_directory = log_directory

I would name this archive_directory or something.

> Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py:55
> +	   return LayoutTestResults.results_from_string(results_html)

Heads up: Ojan is about to break this call into two calls.  One for ORWT and
one for NRWT.

> Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py:64
> +	      
results.set_failure_limit_count(RunTests.NON_INTERACTIVE_FAILURE_LIMIT_COUNT)

Heads up: this is going to be wrong for NWRT.