[webkit-reviews] review granted: [Bug 58504] move caret by word in visual order returns wrong result when caret itself is at word boundary : [Attachment 90437] patch w/ layout test

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 58504: move caret by word in visual order returns wrong result when caret
itself is at word boundary
https://bugs.webkit.org/show_bug.cgi?id=58504

Attachment 90437: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=90437&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90437&action=review

>>> LayoutTests/editing/selection/move-by-word-visually.html:-374
>>> -<div id="div_100" contenteditable>אאא <span id="span_100"
class="specific_test" title="1 left div_100 0">בב</span></div>
>> 
>> Why are we removing this test?
> 
> It was added to address comment #18 in bug 57806
https://bugs.webkit.org/show_bug.cgi?id=57806#c18.
> It is a very specific test just to test a specific path works (at that time,
the whole patch is not completed implemented yet).
> 
> Now since we have the whole patch ready, and I added test case to test word
break stops at right position on *every* visible position. So this specific
test is covered, and we are no longer need it anymore.

Okay, thanks for the clarification.