[webkit-reviews] review granted: [Bug 54179] Change text-based <input> types to use the new shadow DOM model : [Attachment 90744] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 54179: Change text-based <input> types to use the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179

Attachment 90744: Patch 
https://bugs.webkit.org/attachment.cgi?id=90744&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90744&action=review

I would have liked this to be a sub-bug of bug 54179, because it doesn't really
finish the work, but I guess we can track those as separate bugs that block bug
52962.

> Source/WebCore/bindings/objc/DOM.mm:331
> +	       // FIXME: Should provide DOMShadowRoot?

Please file a bug to track this and mention in the FIXME comment.

> Source/WebCore/dom/Element.cpp:1914
> +	   if (parent && parent->isElementNode())

Maybe rewrite as:

if (!parent)
    element = 0
else if ...

> Source/WebCore/rendering/RenderTextControlSingleLine.h:40
> +    // FIXME: Move create*Style() to their classes.

Can you file a bug on this and add to the comment?