[webkit-reviews] review granted: [Bug 59220] Factor PatchAnalysis task out of CommitQueueTask : [Attachment 90739] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 22 12:21:13 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 59220: Factor PatchAnalysis task out of CommitQueueTask
https://bugs.webkit.org/show_bug.cgi?id=59220

Attachment 90739: Patch
https://bugs.webkit.org/attachment.cgi?id=90739&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90739&action=review

OK.  Shouldn't the unit tests move too?

> Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py:213
> +	   assert(self._patch.id() == patch.id())  # CommitQueueTask is not
currently re-useable.

CommitQueueTask?


More information about the webkit-reviews mailing list