[webkit-reviews] review granted: [Bug 59205] Make it harder to use HandleSlot incorrectly : [Attachment 90726] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 59205: Make it harder to use HandleSlot incorrectly
https://bugs.webkit.org/show_bug.cgi?id=59205

Attachment 90726: Patch
https://bugs.webkit.org/attachment.cgi?id=90726&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90726&action=review

r=me

> Source/JavaScriptCore/runtime/WriteBarrier.h:47
> +    JSValue* toJSValueRef() { return this; }

This name was a bit confusing to me because "JSValueRef" is a name in the
JavaScriptCore API.

I'd recommend just having toJSValue(), and using &toJSValue() where needed.