[webkit-reviews] review granted: [Bug 59210] WebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes : [Attachment 90723] [PATCH] Fix v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 22 10:45:03 PDT 2011


Sam Weinig <sam at webkit.org> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 59210: WebKit2: Stop Responsiveness Timer when WebPageProxy closes or
WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=59210

Attachment 90723: [PATCH] Fix v2
https://bugs.webkit.org/attachment.cgi?id=90723&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90723&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:357
> +    process()->responsivenessTimer()->stop();

The remove webpage thing call should be last, please move this above the call
to process()->send(Messages::WebPage::Close(), m_pageID) to keep consistency.


More information about the webkit-reviews mailing list