[webkit-reviews] review denied: [Bug 59210] WebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes : [Attachment 90721] [PATCH] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 22 10:35:57 PDT 2011


Sam Weinig <sam at webkit.org> has denied Brian Weinstein <bweinstein at apple.com>'s
request for review:
Bug 59210: WebKit2: Stop Responsiveness Timer when WebPageProxy closes or
WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=59210

Attachment 90721: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=90721&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90721&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:182
> +    process()->responsivenessTimer()->stop();

This should probably be in close(), not the destructor.


More information about the webkit-reviews mailing list