[webkit-reviews] review granted: [Bug 59082] [GTK] DRT: implement eventSender.scalePageBy : [Attachment 90695] updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 22 06:52:10 PDT 2011
Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 59082: [GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
Attachment 90695: updated patch
https://bugs.webkit.org/attachment.cgi?id=90695&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90695&action=review
Thanks for the fix!
> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:443
> + DumpRenderTreeSupportGtk::scalePageBy(webView, 1.0f, 0.0f, 0.0f);
The WebKit style guidelines say these numbers should just be 1, 0, and 0
respectively (no .0f). Please fix before landing!
More information about the webkit-reviews
mailing list