[webkit-reviews] review denied: [Bug 59193] Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel : [Attachment 90696] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 59193: Web Inspector: Use different SourceFrame instances for
ResourcesPanel and NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=59193

Attachment 90696: Patch
https://bugs.webkit.org/attachment.cgi?id=90696&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90696&action=review

> Source/WebCore/inspector/front-end/NetworkItemView.js:114
> +WebInspector.NetworkItemView.sourceViewForResource = function(resource)

I don't see where this caching is used. Also, should be private.

> Source/WebCore/inspector/front-end/NetworkItemView.js:123
> +WebInspector.NetworkItemView.contentViewForResource = function(resource)

Should be private.

> Source/WebCore/inspector/front-end/NetworkItemView.js:130
> +	   return WebInspector.NetworkItemView.sourceViewForResource(resource);


(do we really cache anything?)

> Source/WebCore/inspector/front-end/ResourcesPanel.js:86
> +    case WebInspector.resourceCategories.documents:

I've seen it earlier. We should not dupe logic like this.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:102
> +    if (!resource._resourcesPanelSourceView)

Can we stop caching views in the resource?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:114
> +    if (!revision._view) {

ditto