[webkit-reviews] review granted: [Bug 59147] Disable MediaPlayerPrivateAVFoundation when using old full screen mode. : [Attachment 90676] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 59147: Disable MediaPlayerPrivateAVFoundation when using old full screen
mode.
https://bugs.webkit.org/show_bug.cgi?id=59147

Attachment 90676: Patch
https://bugs.webkit.org/attachment.cgi?id=90676&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90676&action=review

> Source/WebKit/mac/WebView/WebView.mm:1565
> +#if ENABLE(FULLSCREEN_API)
> +    if (![preferences fullScreenEnabled])
> +	   settings->setAVFoundationEnabled(false);
> +    else
> +#endif

I'm not sure I understand the logic here. If the full screen API is compiled
in, and a client doesn't have it enabled, then we force AVFoundation off. But
if fullscreen API wasn't compiled in at all, wouldn't we still want
AVFoundation turned off? This probably doesn't matter, since we won't actually
face that combination of settings.