[webkit-reviews] review granted: [Bug 58301] Extract map from port to builder name. : [Attachment 89330] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted James Kozianski <koz at chromium.org>'s
request for review:
Bug 58301: Extract map from port to builder name.
https://bugs.webkit.org/show_bug.cgi?id=58301

Attachment 89330: Patch
https://bugs.webkit.org/attachment.cgi?id=89330&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89330&action=review

This looks great. Please address my comments then feel free to commit.

Can you add a FIXME to make the values in this maps be lists? That way we can
encode the fact that each port corresponds to 0-n bots (e.g. release/debug
bots).

> Tools/Scripts/webkitpy/layout_tests/port/builders.py:30
> +# Compiled manually from
http://build.chromium.org/p/chromium/json/builders/help?as_text=1

Maybe add a comment that the None values are ports that don't have a running
bot at build.webkit.org and/or build.chromium.org?

> Tools/Scripts/webkitpy/layout_tests/port/builders.py:32
> +    'chromium-gpu-linux': None,

This should be 'Webkit_Linux_-_GPU'. Ditto for the others chromium ports below.
You can see the full list here:
http://build.chromium.org/f/chromium/layout_test_results/

> Tools/Scripts/webkitpy/layout_tests/port/builders.py:42
> +    'chromium-linux-x86': 'Linux_Tests__dbg__1_',

Can you make the values for the chromium port be the actual bot names and then
add a helper function to this file? getBuilderPathFromName?

> Tools/Scripts/webkitpy/layout_tests/port/builders.py:64
> +    'qt-linux': None,

This one should be "Qt Linux Release", right?