[webkit-reviews] review granted: [Bug 59028] Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class : [Attachment 90600] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 59028: Move complexity from DataTransferItemsChromium and
DataTransferItemChromium for base class
https://bugs.webkit.org/show_bug.cgi?id=59028

Attachment 90600: Patch
https://bugs.webkit.org/attachment.cgi?id=90600&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90600&action=review

The change looks fine, but I think we need to update the other build systems.

> Source/WebCore/WebCore.gypi:2428
> +	       'dom/DataTransferItems.cpp',

Should we add this file to the other build systems (xcode, vcproj, etc)?

> Source/WebCore/dom/DataTransferItems.cpp:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

I suspect this is the wrong copyright.

> Source/WebCore/dom/DataTransferItems.cpp:47
> +unsigned long DataTransferItems::length()

It would be nice in a follow up patch to change these to size_t since that's
what wtf::Vector uses.