[webkit-reviews] review requested: [Bug 59028] Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class : [Attachment 90600] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 14:19:46 PDT 2011


Igor Trindade Oliveira <itrindade.oliveira at gmail.com> has asked  for review:
Bug 59028: Move complexity from DataTransferItemsChromium and
DataTransferItemChromium for base class
https://bugs.webkit.org/show_bug.cgi?id=59028

Attachment 90600: Patch
https://bugs.webkit.org/attachment.cgi?id=90600&action=review

------- Additional Comments from Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>
The forward declaration is not possible in DataTransferItem.h, the template
needs to know about Clipboard, if i do not include it, it would be an
incomplete type.
The setters was removed(my fault) and the enumerator and constructor from
DataTransferItemChromium are private again.
Constify attributes in DataTransferItem.h


More information about the webkit-reviews mailing list