[webkit-reviews] review granted: [Bug 51063] REGRESSION (WebKit2): No context menu appears when right-clicking on windowless Flash plugin : [Attachment 90582] Give windowless plugins' context menus an owner window in the same thread as the plugin

[bugzilla-daemon at webkit.org]

Brian Weinstein <bweinstein at apple.com> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 51063: REGRESSION (WebKit2): No context menu appears when right-clicking on
windowless Flash plugin
https://bugs.webkit.org/show_bug.cgi?id=51063

Attachment 90582: Give windowless plugins' context menus an owner window in the
same thread as the plugin
https://bugs.webkit.org/attachment.cgi?id=90582&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90582&action=review

>>> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:354
>>> +	     hWnd = currentPlugin->m_contextMenuOwnerWindow;
>> 
>> It seems a bit strange to overwrite the hWnd argument here instead of using
a local, but that's probably just because I'm not used to seeing it.
> 
> I don't personally find it strange. And overwriting the hWnd argument is what
this function is all about! But I'm happy to change it if you think it would be
more readable using a local.

It's fine, I just am not as used to seeing that style.