[webkit-reviews] review denied: [Bug 59128] HTMLFormControlElement should not cache its labels list. : [Attachment 90576] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 13:12:21 PDT 2011


Sam Weinig <sam at webkit.org> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 59128: HTMLFormControlElement should not cache its labels list.
https://bugs.webkit.org/show_bug.cgi?id=59128

Attachment 90576: Patch.
https://bugs.webkit.org/attachment.cgi?id=90576&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
This leaves the node list cache in NodeRareData.  I am also not sure we don't
want to cache this value.  Consider the following test.

inputElement.labels.customProperty = 1;
alert(inputElement.labels.customProperty);

That should probably work, but probably won't with this patch or the current
code.


More information about the webkit-reviews mailing list