[webkit-reviews] review granted: [Bug 58402] old-run-webkit-tests/new-run-webkit-tests shouldn't read or write .checksum files : [Attachment 90567] add comment back to ORWT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 11:58:30 PDT 2011


Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 58402: old-run-webkit-tests/new-run-webkit-tests shouldn't read or write
.checksum files
https://bugs.webkit.org/show_bug.cgi?id=58402

Attachment 90567: add comment back to ORWT
https://bugs.webkit.org/attachment.cgi?id=90567&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90567&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:149
>	   if self._options.pixel_tests and driver_output.image_hash:

maybe this check should be driver_output.image instead of
driver_output.image_hash now?


More information about the webkit-reviews mailing list