[webkit-reviews] review denied: [Bug 59113] XMLViewer breaks when scripts are disabled : [Attachment 90553] Unique SecurityOrigins for view source documents

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 59113: XMLViewer breaks when scripts are disabled
https://bugs.webkit.org/show_bug.cgi?id=59113

Attachment 90553: Unique SecurityOrigins for view source documents
https://bugs.webkit.org/attachment.cgi?id=90553&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90553&action=review

> Source/WebCore/xml/XMLTreeViewer.cpp:74
> +    m_document->setSecurityOrigin(uniqueOrigin.get());

This isn't right.  You should be using setForcedSandboxFlags on FrameLoader
before creating the document.