[webkit-reviews] review granted: [Bug 59115] ValidateChangeLogs doesn't work on SVN : [Attachment 90555] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 59115: ValidateChangeLogs doesn't work on SVN
https://bugs.webkit.org/show_bug.cgi?id=59115

Attachment 90555: Patch
https://bugs.webkit.org/attachment.cgi?id=90555&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90555&action=review

> Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:64
> +	       # We diff the ChangeLogs directly because svn-create-patch
doesn't
> +	       # always tell the truth about where the new ChangeLog entry is
in
> +	       # the file.

I would have written this more like:
# Diff ChangeLogs directly because svn-create-patch will move ChangeLog entries
to the
# top automatically, defeating our validation here.

Aka, more substance, less frill. :)  (Not that I don't like the frill.)

> Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:65
> +	       diff = self._tool.scm().diff_for_file(filename)

We may want to diff multiple files at once.  Not sure what the perf
characteristics of SVN are.