[webkit-reviews] review granted: [Bug 59035] WebKit2: Need a way to get a snapshot of the visible contents of a page from the UI Process : [Attachment 90443] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Jessie Berlin <jberlin at webkit.org>'s
request for review:
Bug 59035: WebKit2: Need a way to get a snapshot of the visible contents of a
page from the UI Process
https://bugs.webkit.org/show_bug.cgi?id=59035

Attachment 90443: Patch
https://bugs.webkit.org/attachment.cgi?id=90443&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90443&action=review

> Source/WebKit2/UIProcess/API/C/WKPagePrivate.h:69
> +WK_EXPORT WKImageRef WKPageVisibleContentsSnapshot(WKPageRef pageRef);

This function name needs to Create in its name to indicate the ownership model.
 I think WKPageCreateSnapshotOfVisibleContent() to match the one in the bundle,
would be good.

We usually leave the Ref off the parameter name in the header.